fix: #49 allow newer version of dependencies #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwa5426 Please holler if this looks sane to you. |
DarthHater
reviewed
May 12, 2021
requirements-dev.txt
Outdated
Comment on lines
1
to
3
| pylint>=2.6.0 | ||
| responses>=0.12.0 | ||
| unittest-xml-reporting>=3.0.4 |
There was a problem hiding this comment.
Oof, I hate seeing stuff like this. Why do we have to do it? We can't just pin to a known version?
There was a problem hiding this comment.
Seems fine to pin to specific dev deps, as I'm guessing that will not interfere with Jake being used to scan projects. I will push some changes to lock these dev dep version down (as they used to be).
There was a problem hiding this comment.
Dev deps locked: 5189624
|
@bhamail I agree with preventing the click 8.0.0 issue, I actually ran into that as well. For some of the other non-issue ones maybe it is a good idea to keep them pinned to known good versions or at least a tighter range. |
|
@bhamail seems reasonable to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow newer version of dependencies.
The
clicklibrary had failures when the very recently released v8.0.0 was used, so I added an upper bound to solve that issue for now.Also fixed an error due to db.purge deprecation, replaced with db.truncate call.
cc @bhamail / @DarthHater