Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to get a test running #89

Merged
merged 4 commits into from
Jan 20, 2022
Merged

try to get a test running #89

merged 4 commits into from
Jan 20, 2022

Conversation

bhamail
Copy link
Contributor

@bhamail bhamail commented Jan 14, 2022

Flailings about creating a simple test to appease coverage report.

I suspect a problem with this tox config:
https://github.com/sonatype-nexus-community/jake/blob/main/tox.ini#L27

cc @bhamail / @DarthHater

@bhamail bhamail requested a review from madpah January 14, 2022 19:29
@bhamail bhamail changed the title try to get a test running. may also need some noob dev setup docs. try to get a test running Jan 14, 2022
@madpah
Copy link
Collaborator

madpah commented Jan 17, 2022

There were never any tests (upstream libraries do the tests currently). Would need refactoring to enable testing. Will try to get back to where it was prior to this failure.

Signed-off-by: Paul Horton <phorton@sonatype.com>
@madpah
Copy link
Collaborator

madpah commented Jan 17, 2022

@bhamail - so, it was my bad.

I started the process of adding tests when working on #87, but concluded a notable (non-trivial) refactor would be required to enable testing - so removed tests, but not the empty file.

Forgive me :-)

Have raised #90.

@bhamail
Copy link
Contributor Author

bhamail commented Jan 19, 2022

@bhamail - so, it was my bad.

I started the process of adding tests when working on #87, but concluded a notable (non-trivial) refactor would be required to enable testing - so removed tests, but not the empty file.

Forgive me :-)

Have raised #90.

Hi @madpah, Thanks for looking! Unfortunately, the current build failure in the internal Jenkins build is due to no test results being found - so deleting the test class just gets back to that same failure state.

I'm trying a different option now, that alters the testenv command in tox.ini. If I get that happy, it may suffice as a workaround until #90 happens.

@bhamail
Copy link
Contributor Author

bhamail commented Jan 19, 2022

I think my latest changes have a working unit test and should calm the internal build. Please holler if you see anything horrific.

@bhamail
Copy link
Contributor Author

bhamail commented Jan 20, 2022

No objections, so gonna merge.

@bhamail bhamail merged commit 86afdb5 into main Jan 20, 2022
@bhamail bhamail deleted the fix_test_coverage branch January 20, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants