Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support most recent version of p4c-dpdk #512

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

jafingerhut
Copy link
Contributor

No description provided.

@jafingerhut
Copy link
Contributor Author

jafingerhut commented Feb 9, 2024

Note: With the version of the p4c-dpdk binary being used in the DASH repo as of 2024-Feb-09, that command will fail with the new --context command line option that I have added in the Makefile.

These changes should compile without errors from p4c-dpdk if that executable is updated to a version built from a more recent version of the p4c-dpdk source code, e.g. some time in 2024, but latest should be good.

@jafingerhut jafingerhut marked this pull request as draft February 9, 2024 16:50
@jafingerhut jafingerhut marked this pull request as ready for review February 9, 2024 17:15
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@chrispsommers chrispsommers merged commit 8ba8678 into sonic-net:main Feb 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants