Add Flow API Abstraction Implementation #524
Conversation
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
|
Did you need some help with this @zhixiongniu ? Let us know! |
|
Pipeline error is here: https://github.com/sonic-net/DASH/actions/runs/9779327816/job/26998305213#step:9:15
|
|
[heart] Kristina Moore reacted to your message:
…________________________________
From: Chris Sommers ***@***.***>
Sent: Wednesday, July 10, 2024 4:13:17 PM
To: sonic-net/DASH ***@***.***>
Cc: Kristina Moore ***@***.***>; Comment ***@***.***>
Subject: Re: [sonic-net/DASH] Add flow API Abstraction Implementation (PR #524)
Pipeline error is here: https://github.com/sonic-net/DASH/actions/runs/9779327816/job/26998305213#step:9:15
SAI specs have changed, please run "make sai-headers" locally and commit the changes for review.
—
Reply to this email directly, view it on GitHub<#524 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6GVLWHQWNRRJS6Q5V3ZLVMR3AVCNFSM6AAAAABD2OCC72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQHE2DANZVGM>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Thanks, I have fixed the issue. |
Thanks, I have fixed the issue. |
Signed-off-by: Zhixiong Niu <niu@zhixiong.org>
| is_vlan: false | ||
| deprecated: false |
There was a problem hiding this comment.
this change is odd, maybe it is coming from code merge, do you mind to help revert these changes?
| action set_flow_entry_bulk_get_session_attr( | ||
| /* GRPC Session server IP and port */ | ||
| IPv4ORv6Address bulk_get_session_ip, | ||
| bit<16> bulk_get_session_port, |
There was a problem hiding this comment.
Looks like the mode, limit are missing. Also the name doesn't match with the spec.
zhixiongniu
changed the title
|
Awesome - thanks!
From: Zhixiong ***@***.***>
Sent: Wednesday, July 10, 2024 8:41 PM
To: sonic-net/DASH ***@***.***>
Cc: Kristina Moore ***@***.***>; Comment ***@***.***>
Subject: Re: [sonic-net/DASH] Add flow API Abstraction Implementation (PR #524)
Did you need some help with this @zhixiongniu<https://github.com/zhixiongniu> ? Let us know!
Thanks, I have fixed the issue.
-
Reply to this email directly, view it on GitHub<#524 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6AMLC6DIR7JZEY3TDLZLX5D7AVCNFSM6AAAAABD2OCC72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRHE2TONBTGI>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
dash-pipeline/bmv2/dash_metadata.p4
Outdated
| } | ||
|
|
||
| enum bit<16> dash_flow_entry_bulk_get_session_mode_t | ||
|
|
|
@r12f looks like all checks have passed - is it ready for a merge? |
|
Yep! I think so, it looks aligned with the HLD design now. Is it ok if I approved and merge it? I checked with Marian offline, and he has no problem on this PR as well, but he is OOF recently, so maybe late on the sign-off. |
Sounds good to me, go ahead |
|
Thanks Kristina! |
So sorry, I accidentally closed #507.
This PR achieves same thing as #507 and I am adopting all comments from that PR.
This PR introduces the abstraction of the DASH Flow API, encompassing both the flow table and flow entry, within the bmv2 environment.
For a preview of the SAI introduced by this PR, please refer to the following branch:
SAI Flow API Preview Branch.