-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dash-p4] Add reverse routing table and reverse tunnel support. #603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12f
force-pushed
the
user/r12f/msee-failover
branch
from
July 17, 2024 15:17
040c6bd
to
ae6dab1
Compare
hi @marian-pritsak , @mukeshmv - would you be able to review? |
just checking in to see if we can have a review please? |
marian-pritsak
approved these changes
Jul 31, 2024
Looks like we still have a conflict @r12f |
hi @r12f - do we need a merge on this one since the checks have passed? |
@r12f - should I merge this one? |
Closing per Riff during Community call - switched to flow learning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverse routing table and reverse tunnel are added for supporting the express route gateway bypass scenario for handling the MSEE failover.
The design follows the HLD defined here: #601.
This PR adds the P4 code for API generation and the pipeline design. And the tests will be updated later, due to time limitation.
There are a few known issues in the current implementation:
The 2 known issues are marked as TODO in the code.