Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash-p4] Add reverse routing table and reverse tunnel support. #603

Closed
wants to merge 8 commits into from

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Jul 16, 2024

The reverse routing table and reverse tunnel are added for supporting the express route gateway bypass scenario for handling the MSEE failover.

The design follows the HLD defined here: #601.

This PR adds the P4 code for API generation and the pipeline design. And the tests will be updated later, due to time limitation.

There are a few known issues in the current implementation:

  1. Due to flow API is not fully supported in the P4, the reverse tunnel info could not be applied to the packet, as it only affects the return packets.
  2. The ECMP support is not simple to support with our API design, because we don't know the count of the next hops in this tunnel in P4 pipeline. Either we need to have a predefined size, so we can create a fully populated table, which complicates the libsai generation a ton. Or, we somehow pass in the count, whenever a new member is added.

The 2 known issues are marked as TODO in the code.

@r12f r12f marked this pull request as draft July 16, 2024 15:20
@r12f r12f marked this pull request as ready for review July 17, 2024 15:17
@KrisNey-MSFT
Copy link
Collaborator

hi @marian-pritsak , @mukeshmv - would you be able to review?
TY!

@KrisNey-MSFT
Copy link
Collaborator

just checking in to see if we can have a review please?
@marian-pritsak , @mukeshmv

@KrisNey-MSFT
Copy link
Collaborator

Looks like we still have a conflict @r12f

@KrisNey-MSFT
Copy link
Collaborator

hi @r12f - do we need a merge on this one since the checks have passed?

@KrisNey-MSFT
Copy link
Collaborator

@r12f - should I merge this one?

@KrisNey-MSFT
Copy link
Collaborator

Closing per Riff during Community call - switched to flow learning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants