-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dpapp] add data plane app target #607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyzhai
force-pushed
the
dp_app_add_target_dpapp
branch
from
July 23, 2024 19:01
31e71ac
to
45dfe28
Compare
hi @jimmyzhai - does this need a Reviewer assigned? TY... |
Hi @prsunny - would you have someone who could review this by chance? |
jimmyzhai
force-pushed
the
dp_app_add_target_dpapp
branch
from
August 14, 2024 14:44
45dfe28
to
6937c3d
Compare
@r12f to review |
chrispsommers
approved these changes
Aug 21, 2024
hi @r12f - ok to merge this one? |
jimmyzhai
force-pushed
the
dp_app_add_target_dpapp
branch
from
August 28, 2024 13:24
88de91b
to
56b3974
Compare
r12f
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks Junhua!
r12f
reviewed
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following dpapp HLD - #606, this is the 1st part implementation to add dpapp target in Makefile, which is implemented as a vpp plugin.