Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependent package installation. #49

Closed
wants to merge 1 commit into from

Conversation

joyas-joseph
Copy link
Contributor

Signed-off-by: Joyas Joseph joyas_joseph@dell.com

- Why I did it
Code cleanup.

While analyzing a build failure for sonic-mgmt-framework, it was observed that package installations are happening during the build stage.

05:30:15  make -C src/CLI
05:30:15  make[3]: Entering directory '/sonic/src/sonic-mgmt-framework/src/CLI'
05:30:15  if ! dpkg -l | grep autoconf -c >>/dev/null; then sudo apt-get install autoconf; fi
05:30:15  if ! dpkg -l | grep m4 -c >>/dev/null; then sudo apt-get install m4; fi
05:30:15  if ! dpkg -l | grep libxml2-utils -c >>/dev/null; then sudo apt-get install libxml2-utils; fi
05:30:15  if ! dpkg -l | grep xsltproc -c >>/dev/null; then sudo apt-get install xsltproc; fi
05:30:15  if ! dpkg -l | grep python-lxml -c >>/dev/null; then sudo apt-get install python-lxml; fi
05:30:15  if ! dpkg -l | grep libexpat1-dev -c >>/dev/null; then sudo apt-get install libexpat1-dev; fi
05:30:15  Reading package lists...
05:30:15  Building dependency tree...
05:30:15  Reading state information...
05:30:15  You might want to run 'apt --fix-broken install' to correct these.
05:30:15  The following packages have unmet dependencies:
05:30:15   libnl-route-3-200 : Depends: libnl-3-200 (= 3.4.0-1) but 3.5.0-1 is to be installed
05:30:15   libnl-route-3-dev : Depends: libnl-3-dev (= 3.4.0-1) but 3.5.0-1 is to be installed
05:30:15  E: Unmet dependencies. Try 'apt --fix-broken install' with no packages (or specify a solution).

The required packages are now installed in the sonic-slave docker.

- How I did it
Code change.

- How to verify it
Build sonic-mgmt-framework package and docker

- Description for the changelog
Remove dependent package installation from build stage.

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Contributor

lguohan commented May 27, 2020

retest this please

@tomek-US
Copy link

tomek-US commented May 9, 2023

please resolve the merge conflicts.

@joyas-joseph
Copy link
Contributor Author

Already handled through #76

@jeff-yin jeff-yin deleted the mgmt_build_fix branch September 13, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants