-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support stress routes test on T2 topo #13341
feat: support stress routes test on T2 topo #13341
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -12,8 +14,8 @@ | |||
} | |||
|
|||
|
|||
def get_crm_resources(duthost, resource, status): | |||
return duthost.get_crm_resources().get("main_resources").get(resource).get(status) | |||
def get_crm_resource_status(duthost, resource, status, namespace=DEFAULT_NAMESPACE): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you changed this funciton name, can you make sure all other places that were using get_crm_resources
are fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wenyiz2021, I did some search in the repo and found the following tests are using function get_crm_resources()
(same function name from various places):
- arp/test_stress_arp.py
- crm/test_crm.py
- fdb/test_fdb_mac_move.py
- vxlan/test_vxlan_crm.py
- vxlan/test_vxlan_ecmp.py
Then I ran these tests and can confirm they are still working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @cyw233 , should we change other test scripts to support T2 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yutongzhang-microsoft, we have checked all the skipped tests on T2 and documented the ones that indeed need to be supported on T2. For example, this test_stress_routes
should run on T2, while test_stress_arp
should always be skipped on T2 because it's supposed to be run on T0 only.
This is the very beginning of the T2 test gap and we will make more test cases supported on T2, for example, supporting test_bfd.py
on T2 is my very next ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
every util has its own get_crm_resources
duthost has its own get_crm_resources
this get_crm_resource_status is specific to tests/stress/xx tests
@cyw233 PR conflicts with 202205 branch |
ack |
Cherry pick PR to merge into 202205 branch: #13394 |
Description of PR Support test_stress_routes.py on T2 topology. Summary: Fixes # (issue) Microsoft ADO 28357470 Approach What is the motivation for this PR? Currently, the test_stress_routes.py only runs on the following topologies: T0, T1, M0, MX. We wanted to support this test on T2 topology as well. How did you do it? Add T2 topology marker and make necessary changes to make the test pass on a T2 testbed. How did you verify/test it? I run the updated test on a T2 testbed and confirm it passed. co-authorized by: jianquanye@microsoft.com
Description of PR Support test_stress_routes.py on T2 topology. Summary: Fixes # (issue) Microsoft ADO 28357470 Approach What is the motivation for this PR? Currently, the test_stress_routes.py only runs on the following topologies: T0, T1, M0, MX. We wanted to support this test on T2 topology as well. How did you do it? Add T2 topology marker and make necessary changes to make the test pass on a T2 testbed. How did you verify/test it? I run the updated test on a T2 testbed and confirm it passed. co-authorized by: jianquanye@microsoft.com
Cherry-pick PR to 202405: #13421 |
Description of PR Support test_stress_routes.py on T2 topology. Summary: Fixes # (issue) Microsoft ADO 28357470 Approach What is the motivation for this PR? Currently, the test_stress_routes.py only runs on the following topologies: T0, T1, M0, MX. We wanted to support this test on T2 topology as well. How did you do it? Add T2 topology marker and make necessary changes to make the test pass on a T2 testbed. How did you verify/test it? I run the updated test on a T2 testbed and confirm it passed. co-authorized by: jianquanye@microsoft.com
Description of PR
Support
test_stress_routes.py
on T2 topology.Summary:
Fixes # (issue) Microsoft ADO 28357470
Type of change
Back port request
Approach
What is the motivation for this PR?
Currently, the
test_stress_routes.py
only runs on the following topologies: T0, T1, M0, MX. We wanted to support this test on T2 topology as well.How did you do it?
Add T2 topology marker and make necessary changes to make the test pass on a T2 testbed.
How did you verify/test it?
I run the updated test on a T2 testbed and confirm it passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation