Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACACS] Add debug info for check nss config missing issue. #13344

Merged

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Jun 18, 2024

Add debug info for check nss config missing issue.

Why I did it

TACACS accounting test case randomly failed because can't login device with remote account.
According syslog, seems nss config file been deleted on device.
Add debug log to check and confirm the root cause.

How I did it

Add debug info for check nss config missing issue.

How to verify it

Pass all test case.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Add debug info for check nss config missing issue.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 changed the title Add debug info for check nss config missing issue. [TACACS] Add debug info for check nss config missing issue. Jun 18, 2024
@liuh-80 liuh-80 marked this pull request as ready for review June 19, 2024 01:32
@liuh-80 liuh-80 requested review from wangxin and ganglyu June 19, 2024 01:32
@ganglyu ganglyu self-requested a review June 20, 2024 01:32
tests/tacacs/conftest.py Outdated Show resolved Hide resolved
@ganglyu ganglyu self-requested a review June 20, 2024 04:52
@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 25, 2024

/azpw Azure.sonic-mgmt

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 25, 2024

Close and re open tp trigger validation

@liuh-80 liuh-80 closed this Jun 25, 2024
@liuh-80 liuh-80 reopened this Jun 25, 2024
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 8007056 into sonic-net:master Jun 26, 2024
18 checks passed
@StormLiangMS
Copy link
Collaborator

@bingwang-ms @yxieca for 202311 / 202405 cherry pick.

@mssonicbld
Copy link
Collaborator

@liuh-80 PR conflicts with 202311 branch

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 26, 2024
…t#13344)

Add debug info for check nss config missing issue.

Why I did it
TACACS accounting test case randomly failed because can't login device with remote account.
According syslog, seems nss config file been deleted on device.
Add debug log to check and confirm the root cause.

How I did it
Add debug info for check nss config missing issue.

How to verify it
Pass all test case.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #13456

mssonicbld pushed a commit that referenced this pull request Jun 26, 2024
Add debug info for check nss config missing issue.

Why I did it
TACACS accounting test case randomly failed because can't login device with remote account.
According syslog, seems nss config file been deleted on device.
Add debug log to check and confirm the root cause.

How I did it
Add debug info for check nss config missing issue.

How to verify it
Pass all test case.
@yxieca
Copy link
Collaborator

yxieca commented Jun 26, 2024

@liuh-80 is this change needed in 202311 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants