-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test_reload_configuration_checks] using async mode to execute config reload CMD #13361
Merged
wangxin
merged 1 commit into
sonic-net:master
from
lipxu:20240619_publicmaster_sshtimeout
Jun 19, 2024
Merged
[test_reload_configuration_checks] using async mode to execute config reload CMD #13361
wangxin
merged 1 commit into
sonic-net:master
from
lipxu:20240619_publicmaster_sshtimeout
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xuliping <xuliping@microsoft.com>
wangxin
approved these changes
Jun 19, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 4, 2024
What is the motivation for this PR? Case failed due to no response after execting cmd "config reload" with timeout threshold. Ansible ssh timeout value is 60s. out = duthost.shell("sudo config reload -y", executable="/bin/bash", module_ignore_errors=True) > assert "Retry later" in out['stdout'] E KeyError: 'stdout' out = {'failed': True, 'msg': 'Timeout (62s) waiting for privilege escalation prompt: ', '_ansible_no_log': False} How did you do it? Using async mode to run the CMD How did you verify/test it? Run the case locally and with pipeline Signed-off-by: xuliping <xuliping@microsoft.com>
Cherry-pick PR to 202311: #13566 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 6, 2024
What is the motivation for this PR? Case failed due to no response after execting cmd "config reload" with timeout threshold. Ansible ssh timeout value is 60s. out = duthost.shell("sudo config reload -y", executable="/bin/bash", module_ignore_errors=True) > assert "Retry later" in out['stdout'] E KeyError: 'stdout' out = {'failed': True, 'msg': 'Timeout (62s) waiting for privilege escalation prompt: ', '_ansible_no_log': False} How did you do it? Using async mode to run the CMD How did you verify/test it? Run the case locally and with pipeline Signed-off-by: xuliping <xuliping@microsoft.com>
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
Jul 6, 2024
lizhijianrd
pushed a commit
to lizhijianrd/sonic-mgmt
that referenced
this pull request
Aug 3, 2024
What is the motivation for this PR? Case failed due to no response after execting cmd "config reload" with timeout threshold. Ansible ssh timeout value is 60s. out = duthost.shell("sudo config reload -y", executable="/bin/bash", module_ignore_errors=True) > assert "Retry later" in out['stdout'] E KeyError: 'stdout' out = {'failed': True, 'msg': 'Timeout (62s) waiting for privilege escalation prompt: ', '_ansible_no_log': False} How did you do it? Using async mode to run the CMD How did you verify/test it? Run the case locally and with pipeline Signed-off-by: xuliping <xuliping@microsoft.com>
This was referenced Aug 3, 2024
bingwang-ms
pushed a commit
that referenced
this pull request
Aug 6, 2024
* using async mode to execut config reload cmd (#13361) Signed-off-by: xuliping <xuliping@microsoft.com> Co-authored-by: Liping Xu <108326363+lipxu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
28387106
Type of change
Back port request
Approach
What is the motivation for this PR?
Case failed due to no response after execting cmd "config reload" with timeout threshold.
Ansible ssh timeout value is 60s.
How did you do it?
Using async mode to run the CMD
How did you verify/test it?
Run the case locally and with pipeline
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation