Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test_reload_configuration_checks] using async mode to execute config reload CMD #13361

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

lipxu
Copy link
Contributor

@lipxu lipxu commented Jun 19, 2024

Description of PR

Summary:
Fixes # (issue)
28387106

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Case failed due to no response after execting cmd "config reload" with timeout threshold.
Ansible ssh timeout value is 60s.

        out = duthost.shell("sudo config reload -y",
                            executable="/bin/bash", module_ignore_errors=True)
>       assert "Retry later" in out['stdout']
E       KeyError: 'stdout'


out        = {'failed': True, 'msg': 'Timeout (62s) waiting for privilege escalation prompt: ', '_ansible_no_log': False}

How did you do it?

Using async mode to run the CMD

How did you verify/test it?

Run the case locally and with pipeline

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: xuliping <xuliping@microsoft.com>
@lipxu lipxu requested a review from prgeor as a code owner June 19, 2024 07:02
@wangxin wangxin merged commit f48d1ba into sonic-net:master Jun 19, 2024
14 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 4, 2024
What is the motivation for this PR?
Case failed due to no response after execting cmd "config reload" with timeout threshold.
Ansible ssh timeout value is 60s.
        out = duthost.shell("sudo config reload -y",
                            executable="/bin/bash", module_ignore_errors=True)
>       assert "Retry later" in out['stdout']
E       KeyError: 'stdout'

out        = {'failed': True, 'msg': 'Timeout (62s) waiting for privilege escalation prompt: ', '_ansible_no_log': False}
How did you do it?
Using async mode to run the CMD

How did you verify/test it?
Run the case locally and with pipeline

Signed-off-by: xuliping <xuliping@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #13566

mssonicbld pushed a commit that referenced this pull request Jul 6, 2024
What is the motivation for this PR?
Case failed due to no response after execting cmd "config reload" with timeout threshold.
Ansible ssh timeout value is 60s.
        out = duthost.shell("sudo config reload -y",
                            executable="/bin/bash", module_ignore_errors=True)
>       assert "Retry later" in out['stdout']
E       KeyError: 'stdout'

out        = {'failed': True, 'msg': 'Timeout (62s) waiting for privilege escalation prompt: ', '_ansible_no_log': False}
How did you do it?
Using async mode to run the CMD

How did you verify/test it?
Run the case locally and with pipeline

Signed-off-by: xuliping <xuliping@microsoft.com>
lizhijianrd pushed a commit to lizhijianrd/sonic-mgmt that referenced this pull request Aug 3, 2024
What is the motivation for this PR?
Case failed due to no response after execting cmd "config reload" with timeout threshold.
Ansible ssh timeout value is 60s.
        out = duthost.shell("sudo config reload -y",
                            executable="/bin/bash", module_ignore_errors=True)
>       assert "Retry later" in out['stdout']
E       KeyError: 'stdout'

out        = {'failed': True, 'msg': 'Timeout (62s) waiting for privilege escalation prompt: ', '_ansible_no_log': False}
How did you do it?
Using async mode to run the CMD

How did you verify/test it?
Run the case locally and with pipeline

Signed-off-by: xuliping <xuliping@microsoft.com>
bingwang-ms pushed a commit that referenced this pull request Aug 6, 2024
* using async mode to execut config reload cmd (#13361)

Signed-off-by: xuliping <xuliping@microsoft.com>
Co-authored-by: Liping Xu <108326363+lipxu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants