Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run telemetry tests on all DUT types in a multi-dut setup #6098

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

sanmalho-git
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

The existing telemetry tests used rand_one_dut_hostname which would run on a randomly selected DUT in a multi-dut testbed like T2 chassis. In T2 chassis, this random dut could be a supervisor card, and in this scenario, some of the telemetry tests would fail because of dependency on Ethernet0 frontpanel port.

How did you do it?

  • Use enum_rand_one_dut_per_hwsku_hostname instead of rand_one_dut_hostname to run all all DUT types.
  • skip test_telemetry_output and test_virtualdb_table_streaming on supervisor card as dealing with Ethernet0 port that is not present on supervisor card.

How did you verify/test it?

Tested on T2 chassis and confirmed that the tests pass and run against linecard and supervisor card.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

wangxin
wangxin previously approved these changes Aug 10, 2022
Use enum_rand_one_dut_per_hwsku_hostname instead of rand_one_dut_hostname
Also, skip test_telemetry_output and test_virtualdb_table_streaming on supervisor card as dealing with Ethernet0 port that is not present on supervisor card.
@tjchadaga tjchadaga merged commit 10e43f2 into sonic-net:master Oct 27, 2022
wangxin pushed a commit that referenced this pull request Oct 31, 2022
Use enum_rand_one_dut_per_hwsku_hostname instead of rand_one_dut_hostname
Also, skip test_telemetry_output and test_virtualdb_table_streaming on supervisor card as dealing with Ethernet0 port that is not present on supervisor card.
lolyu pushed a commit to lolyu/sonic-mgmt that referenced this pull request Dec 19, 2022
…Azure/sonic-mgmt into internal

Fix merge conflicts.
Commit history:

- Modified args for some of the calls (sonic-net#6605)
- Run telemetry tests on all DUT types in a multi-dut setup (sonic-net#6098)
- [dualtor]: Fix loopback route removal (sonic-net#6555)
- Added support for one portChannel and one routed interface if two por… (sonic-net#5331)
- Use config_reload when recovering from internal interfaces that are in down state (sonic-net#6076)
- Added python fixture for resetting config changes to fix nightly backend snmp test failures (sonic-net#6607)
- Fix Python3 RuntimeError - dictionary changed size during iteration (sonic-net#6646)
- [mx] Add docs for mx topo (sonic-net#6634)
- [topo_mx] Add new topo for BMC Mgmt ToR Router (sonic-net#6636)
- [mx] Enhance announce routes to support MX topo (sonic-net#6635)
- Merge branch 'azure-master' into dev/yaqiangzhu/internal_merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants