Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python fixture for resetting config changes to fix nightly backend snmp test failures #6607

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

developfast
Copy link
Contributor

Description of PR

Summary:
In the nightly tests, there were snmp failures on the backend T0 and T1, the cause of which was related to config issues with the DUT, specifically the queue counterpoll being disabled by another test beforehand. To solve this issue, before any of the snmp tests are executed, the queue counterpoll is enabled in a python fixture in the associated conftest.py file.
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Fix snmp test failures occuring in nightly tests on backend T0 and T1

How did you do it?

Adding a python fixture that enables the queue counterpoll before the snmp tests are run

How did you verify/test it?

Ran the snmp test suite on a DUT in the lab, with the config disabled initially to see that the tests pass

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@azure-pipelines
Copy link

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snmp/conftest.py:4:1: E302 expected 2 blank lines, found 1
tests/snmp/conftest.py:9:1: E302 expected 2 blank lines, found 1
tests/snmp/conftest.py:14:1: E302 expected 2 blank lines, found 1

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

neethajohn
neethajohn previously approved these changes Oct 24, 2022
@neethajohn neethajohn merged commit dbb5e8d into sonic-net:master Oct 28, 2022
wangxin pushed a commit that referenced this pull request Oct 31, 2022
…end snmp test failures (#6607)

In the nightly tests, there were snmp failures on the backend T0 and T1, the cause of which was related to config issues with the DUT, specifically the queue counterpoll being disabled by another test beforehand. To solve this issue, before any of the snmp tests are executed, the queue counterpoll is enabled in a python fixture in the associated conftest.py file.

What is the motivation for this PR?
Fix snmp test failures occuring in nightly tests on backend T0 and T1

How did you do it?
Adding a python fixture that enables the queue counterpoll before the snmp tests are run

How did you verify/test it?
Ran the snmp test suite on a DUT in the lab, with the config disabled initially to see that the tests pass
wangxin pushed a commit that referenced this pull request Oct 31, 2022
…end snmp test failures (#6607)

In the nightly tests, there were snmp failures on the backend T0 and T1, the cause of which was related to config issues with the DUT, specifically the queue counterpoll being disabled by another test beforehand. To solve this issue, before any of the snmp tests are executed, the queue counterpoll is enabled in a python fixture in the associated conftest.py file.

What is the motivation for this PR?
Fix snmp test failures occuring in nightly tests on backend T0 and T1

How did you do it?
Adding a python fixture that enables the queue counterpoll before the snmp tests are run

How did you verify/test it?
Ran the snmp test suite on a DUT in the lab, with the config disabled initially to see that the tests pass
lolyu pushed a commit to lolyu/sonic-mgmt that referenced this pull request Dec 19, 2022
…Azure/sonic-mgmt into internal

Fix merge conflicts.
Commit history:

- Modified args for some of the calls (sonic-net#6605)
- Run telemetry tests on all DUT types in a multi-dut setup (sonic-net#6098)
- [dualtor]: Fix loopback route removal (sonic-net#6555)
- Added support for one portChannel and one routed interface if two por… (sonic-net#5331)
- Use config_reload when recovering from internal interfaces that are in down state (sonic-net#6076)
- Added python fixture for resetting config changes to fix nightly backend snmp test failures (sonic-net#6607)
- Fix Python3 RuntimeError - dictionary changed size during iteration (sonic-net#6646)
- [mx] Add docs for mx topo (sonic-net#6634)
- [topo_mx] Add new topo for BMC Mgmt ToR Router (sonic-net#6636)
- [mx] Enhance announce routes to support MX topo (sonic-net#6635)
- Merge branch 'azure-master' into dev/yaqiangzhu/internal_merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants