-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added python fixture for resetting config changes to fix nightly backend snmp test failures #6607
Conversation
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
…end snmp test failures (#6607) In the nightly tests, there were snmp failures on the backend T0 and T1, the cause of which was related to config issues with the DUT, specifically the queue counterpoll being disabled by another test beforehand. To solve this issue, before any of the snmp tests are executed, the queue counterpoll is enabled in a python fixture in the associated conftest.py file. What is the motivation for this PR? Fix snmp test failures occuring in nightly tests on backend T0 and T1 How did you do it? Adding a python fixture that enables the queue counterpoll before the snmp tests are run How did you verify/test it? Ran the snmp test suite on a DUT in the lab, with the config disabled initially to see that the tests pass
…end snmp test failures (#6607) In the nightly tests, there were snmp failures on the backend T0 and T1, the cause of which was related to config issues with the DUT, specifically the queue counterpoll being disabled by another test beforehand. To solve this issue, before any of the snmp tests are executed, the queue counterpoll is enabled in a python fixture in the associated conftest.py file. What is the motivation for this PR? Fix snmp test failures occuring in nightly tests on backend T0 and T1 How did you do it? Adding a python fixture that enables the queue counterpoll before the snmp tests are run How did you verify/test it? Ran the snmp test suite on a DUT in the lab, with the config disabled initially to see that the tests pass
…Azure/sonic-mgmt into internal Fix merge conflicts. Commit history: - Modified args for some of the calls (sonic-net#6605) - Run telemetry tests on all DUT types in a multi-dut setup (sonic-net#6098) - [dualtor]: Fix loopback route removal (sonic-net#6555) - Added support for one portChannel and one routed interface if two por… (sonic-net#5331) - Use config_reload when recovering from internal interfaces that are in down state (sonic-net#6076) - Added python fixture for resetting config changes to fix nightly backend snmp test failures (sonic-net#6607) - Fix Python3 RuntimeError - dictionary changed size during iteration (sonic-net#6646) - [mx] Add docs for mx topo (sonic-net#6634) - [topo_mx] Add new topo for BMC Mgmt ToR Router (sonic-net#6636) - [mx] Enhance announce routes to support MX topo (sonic-net#6635) - Merge branch 'azure-master' into dev/yaqiangzhu/internal_merge
Description of PR
Summary:
In the nightly tests, there were snmp failures on the backend T0 and T1, the cause of which was related to config issues with the DUT, specifically the queue counterpoll being disabled by another test beforehand. To solve this issue, before any of the snmp tests are executed, the queue counterpoll is enabled in a python fixture in the associated conftest.py file.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix snmp test failures occuring in nightly tests on backend T0 and T1
How did you do it?
Adding a python fixture that enables the queue counterpoll before the snmp tests are run
How did you verify/test it?
Ran the snmp test suite on a DUT in the lab, with the config disabled initially to see that the tests pass
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation