Fix Python3 RuntimeError - dictionary changed size during iteration

[wsycqyz]

Description of PR

Summary:
Fix Python3 RuntimeError - dictionary changed size during iteration

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911
• 202012
• 202205

Approach

What is the motivation for this PR?

Python3 migration: In Python3, you cannot add/remove elements in a dictionary while iterating through it.

How did you do it?

Use copy(). This way you iterate over the original dictionary fields and on the fly can change the desired dict.

How did you verify/test it?

Both Python2 and Python3 can run bgp/test_bgp_facts.py successfully.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

[azure-pipelines]

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/plugins/conditional_mark/init.py:126:5: F841 local variable 'e' is assigned to but never used
tests/common/plugins/conditional_mark/init.py:129:1: E302 expected 2 blank lines, found 1
tests/common/plugins/conditional_mark/init.py:158:1: E302 expected 2 blank lines, found 1
tests/common/plugins/conditional_mark/init.py:212:1: E302 expected 2 blank lines, found 1
tests/common/plugins/conditional_mark/init.py:228:121: E501 line too long (174 > 120 characters)
tests/common/plugins/conditional_mark/init.py:242:1: E302 expected 2 blank lines, found 1
tests/common/plugins/conditional_mark/init.py:270:1: E302 expected 2 blank lines, found 1
tests/common/plugins/conditional_mark/init.py:298:1: E302 expected 2 blank lines, found 1
tests/common/plugins/conditional_mark/init.py:449:5: F841 local variable 'e' is assigned to but never used
tests/common/plugins/conditional_mark/init.py:456:92: E502 the backslash is redundant between brackets
tests/common/plugins/conditional_mark/init.py:457:5: E128 continuation line under-indented for visual indent
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[azure-pipelines]

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/plugins/conditional_mark/init.py:464:9: E128 continuation line under-indented for visual indent
tests/common/plugins/conditional_mark/init.py:488:121: E501 line too long (131 > 120 characters)
tests/common/plugins/conditional_mark/init.py:490:121: E501 line too long (131 > 120 characters)

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>