Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Static DNS test plan #8436

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

nhe-NV
Copy link
Contributor

@nhe-NV nhe-NV commented May 26, 2023

Describe the test cases that will cover the static DNS feature: https://github.com/sonic-net/SONiC/blob/master/doc/static-dns/static_dns.md

Description of PR

Summary: Test plan for the static DNS nameserver
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Decrible what kind of test case will be added to cover the static dns nameserver test case

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@liat-grozovik
Copy link
Collaborator

@yxieca do you wish to assign someone for a review? if not, can we merge?

@yxieca
Copy link
Collaborator

yxieca commented Jun 23, 2023

@yxieca do you wish to assign someone for a review? if not, can we merge?

Can we have a presentation at the test subgroup meeting before merging?

@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Jun 23, 2023 via email

@yxieca
Copy link
Collaborator

yxieca commented Jun 23, 2023

Can we schedule it for the conning Wednesday meeting? D Get Outlook for iOShttps://aka.ms/o0ukef

________________________________ From: Ying Xie @.> Sent: Friday, June 23, 2023 3:13:35 AM To: sonic-net/sonic-mgmt @.> Cc: Liat Grozovik @.>; Comment @.> Subject: Re: [sonic-net/sonic-mgmt] Add Static DNS test plan (PR #8436) @yxiecahttps://github.com/yxieca do you wish to assign someone for a review? if not, can we merge? Can we have a presentation at the test subgroup meeting before merging? — Reply to this email directly, view it on GitHub<#8436 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKTABA2U4TTQBWK3ZUTBVPTXMTNS7ANCNFSM6AAAAAAYP5UOGM. You are receiving this because you commented.Message ID: @.***>

There is topic scheduled next Wed already. But this PR can be on standby if there is time left. I can schedule it for 3 week sfrom now for sure.

@liat-grozovik liat-grozovik merged commit 4ce8483 into sonic-net:master Aug 27, 2023
12 checks passed
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants