Add new functionality to syncd_init_common.sh, to use common sai.profile #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazariig
approved these changes
Feb 8, 2024
Merged
11 tasks
|
/azpw run Azure.sonic-sairedis |
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
is this ready to merge ? |
noaOrMlnx
force-pushed
the
syncd_init_common_improvements
branch
from
24c5af0
to
3be8e7a
Compare
kcudnik
approved these changes
Feb 22, 2024
|
Hi @kcudnik, |
|
@noaOrMlnx please check the checkers failures. without them passing we cannot move forward and merge. 10x |
|
/azpw run Azure.sonic-sairedis |
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik checkers pass, can you please help with merging the PR? |
|
@yxieca , Can you please cherry pick to 202311 ? |
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Feb 26, 2024
…ile (sonic-net#1352) Changed config_mlnx_syncd() functionality to use common sai.profile for all SKUs, then apply the specific SKU sai.profile on top of it, and remove duplications. Why I did it To have the ability to add common parameters to only 1 file instead of all SKUs.
|
Cherry-pick PR to 202311: #1359 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 27, 2024
…ile (#1352) Changed config_mlnx_syncd() functionality to use common sai.profile for all SKUs, then apply the specific SKU sai.profile on top of it, and remove duplications. Why I did it To have the ability to add common parameters to only 1 file instead of all SKUs.
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 27, 2024
### Why I did it Update sonic-sairedis submodule pointer to include the following: Add new functionality to syncd_init_common.sh, to use common sai.profile (sonic-net/sonic-sairedis#1352) ### How I did it Advance sonic-sairedis pointer
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
### Why I did it Update sonic-sairedis submodule pointer to include the following: Add new functionality to syncd_init_common.sh, to use common sai.profile (sonic-net/sonic-sairedis#1352) ### How I did it Advance sonic-sairedis pointer
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
### Why I did it Update sonic-sairedis submodule pointer to include the following: Add new functionality to syncd_init_common.sh, to use common sai.profile (sonic-net/sonic-sairedis#1352) ### How I did it Advance sonic-sairedis pointer
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
### Why I did it Update sonic-sairedis submodule pointer to include the following: Add new functionality to syncd_init_common.sh, to use common sai.profile (sonic-net/sonic-sairedis#1352) ### How I did it Advance sonic-sairedis pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed config_mlnx_syncd() functionality to use common sai.profile for all SKUs, then apply the specific SKU sai.profile on top of it, and remove duplications.
Why I did it
To have the ability to add common parameters to only 1 file instead of all SKUs.