-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202405][syncd] Enable bulk api for neighbor entries #1415
Conversation
@Ndancejic Can you please check the failure in PR test? |
@Ndancejic can you please fix CI errors? |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
57b8e6f
to
85ffdae
Compare
SAI 1.11.0 added support for bulk neighbor entries. Adding support for neighbor bulk operations to syncd. * added neighbor entry capability to bulk operations in syncd * added unit tests for neighbor bulk operations * added code coverage for neighbor bulk operations Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
85ffdae
to
9e4cc13
Compare
@Ndancejic , can you check the build failure? I thought this was already part of 202405. Lets get this resolved asap. |
Tested on a version without this change as well, test_pfcwd_shared_egress_acl_table.py is failing even without this. I would be happy to help debug the test issue, but since this change is critical for 202405 and is currently failing other PR tests maybe it would be good to merge since all other tests are passing |
Test failure in here is for test_pfcwd_shared_egress_acl_table failing. This is seen starting from a sonic-swss commit (sonic-net/sonic-swss@4f0d40c). This specific failure is fixing a failure in mux test cases. Because it is a net improvement (mux configuration uses the bulk APIs on 202405 branch, which apparently was missing in sairedis when the branch cutoff happened), I'm approving and force merging this PR. |
@bingwang-ms FYI |
@saiarcot895 i see that |
SAI 1.11.0 added support for bulk neighbor entries. Adding support for neighbor bulk operations to syncd.
cherry-pick of #1373. which includes the commits below:
commit 57b8e6f (HEAD -> ndancejic202405, dancejic/ndancejic202405, 202405)
Author: Nikola Dancejic ndancejic@microsoft.com
Date: Tue May 14 18:23:55 2024 +0000
commit fbe3fc7
Author: Nikola Dancejic ndancejic@microsoft.com
Date: Fri May 24 17:57:45 2024 +0000
commit a5b2bbb
Author: Nikola Dancejic ndancejic@microsoft.com
Date: Tue May 28 01:16:46 2024 +0000