Add notification consumer and producer #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we have unit test for this? |
|
I can add this in next cr |
|
ack |
donNewtonAlpha
pushed a commit
to pins/sonic-swss-common-public
that referenced
this pull request
Mar 17, 2022
This is causing a build failure in p4rt app. Closes pins/sonic-swss-common#6 Resolves sonic-net#6 Github-Pr-Head-Sha: d71b4725a1776da7ebdf1c767273932a15835071 NO_BUG=PINS pull request GitOrigin-RevId: 7a95a5674025732ddb1052c846a8aa6c755fa873 Change-Id: I4f2a08bab72c22f51af5b64d753e6cc30f92e385
zbud-msft
pushed a commit
to zbud-msft/sonic-swss-common
that referenced
this pull request
Aug 3, 2022
ptr to shared_ptr per review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.