Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert recirc port change #1813

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Revert recirc port change #1813

merged 1 commit into from
Jul 6, 2021

Conversation

ysmanman
Copy link
Contributor

What I did
Revert the special handling for recirc port.

Why I did it
Recirc port support has been added to recent versions of DNX SAI. The earlier special handling for recirc port is not required anymore and thus reverted.

How I verified it
I tested the PR with SAI 5.0.0.5 and verified inband port came up and functioned correctly.

Details if related

Recirc port support has been added to recent versions of DNX SAI.
The earlier special handling for recirc port is not required anymore
and thus reverted.
@ysmanman ysmanman requested a review from prsunny as a code owner June 30, 2021 20:50
@prsunny
Copy link
Collaborator

prsunny commented Jun 30, 2021

please give the PR number that you reverted

@ysmanman
Copy link
Contributor Author

please give the PR number that you reverted

@prsunny This is the PR that added special handling for recirc ports: #1530.

@prsunny prsunny requested a review from abdosi June 30, 2021 22:27
@abdosi abdosi merged commit 7c7c451 into sonic-net:master Jul 6, 2021
judyjoseph pushed a commit that referenced this pull request Aug 10, 2021
Recirc port support has been added to recent versions of DNX SAI.
The earlier special handling for recirc port is not required anymore
and thus reverted.
@qiluo-msft
Copy link
Contributor

qiluo-msft commented Sep 16, 2021

This is not an exact/complete revert of 1530.

Since it is merged. Can we revert both commits

7c7c4513 2021-07-06 | Revert recirc port change (#1813) [Song Yuan]
5ef4b382 2021-06-01 | Add support for recirc port and everflow (#1530) [Song Yuan]

@prsunny @abdosi for vis.

qiluo-msft added a commit to qiluo-msft/sonic-swss that referenced this pull request Sep 16, 2021
@qiluo-msft
Copy link
Contributor

I create another PR #1911 to revert both.

@qiluo-msft
Copy link
Contributor

@ysmanman Could you help check why swss-common master branch keep failing on test case "test_recirc_port"?
https://dev.azure.com/mssonic/build/_build/results?buildId=36930&view=ms.vss-test-web.build-test-results-tab

raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
Recirc port support has been added to recent versions of DNX SAI.
The earlier special handling for recirc port is not required anymore
and thus reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants