[everflow]: Fixed issue with accessing ACL counters of inactive session. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you describe the nature of the issue a little bit more? what is the issue when accessing acl counters of inactive session? what is inactive session? |
lguohan
approved these changes
Apr 11, 2017
|
@lguohan Session with inactive state is session with unresolved route or next hop for its DST IP. It is not configured on hardware (so SAI OID is unavailable). To create ACL rule with action mirror we should have session in active state to be able to get its OID. If session is inactive ACL rules that depends on it can't be created on HW and have inactive state. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…l when available (sonic-net#188) * [fast-reboot] Explicitly call Linux native reboot tool * [reboot tool] Reboot device with platform specific tool when available /usr/bin is in front of /sbin in search path. Adding reboot script here will get executed when reboot was called without absolute path. This script will call platform specific reboot tool (name: platform_reboot under device folder) when available. Otherwise, dispatch to native Linux reboot. * [reboot] call sync before calling platform specific reboot tool The platform specific reboot tool could be power cycling. * [reboot] sleep 3 seconds after sync-ing * [reboot] also stop snmp service
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
- Remove counter collection timer - Change counter thread log to INFO
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
#### Description
xcvrd crashes with the following trace for few media when processing application advertisement.
```
Traceback (most recent call last):
File "/usr/local/bin/xcvrd", line 8, in <module>
sys.exit(main())
File "/usr/local/lib/python3.7/dist-packages/xcvrd/xcvrd.py", line 1415, in main
xcvrd.run()
File "/usr/local/lib/python3.7/dist-packages/xcvrd/xcvrd.py", line 1363, in run
self.init()
File "/usr/local/lib/python3.7/dist-packages/xcvrd/xcvrd.py", line 1328, in init
post_port_sfp_dom_info_to_db(is_warm_start, self.stop_event)
File "/usr/local/lib/python3.7/dist-packages/xcvrd/xcvrd.py", line 501, in post_port_sfp_dom_info_to_db
post_port_sfp_info_to_db(logical_port_name, int_tbl[asic_index], transceiver_dict, stop_event)
File "/usr/local/lib/python3.7/dist-packages/xcvrd/xcvrd.py", line 293, in post_port_sfp_info_to_db
port_info_dict = _wrapper_get_transceiver_info(physical_port)
File "/usr/local/lib/python3.7/dist-packages/xcvrd/xcvrd.py", line 164, in _wrapper_get_transceiver_info
return platform_chassis.get_sfp(physical_port).get_transceiver_info()
File "/usr/local/lib/python3.7/dist-packages/sonic_platform/sfp.py", line 621, in get_transceiver_info
sfp_application_type_list[i * 4], sfp_application_type_list[i * 4 + 1])
File "/usr/local/lib/python3.7/dist-packages/sonic_platform_base/sonic_sfp/qsfp_dd.py", line 95, in parse_application
media_result = sfp_media_type_dict[media_interface]
KeyError: '88'
```
#### Motivation and Context
To fix the crash, check whether the media interface key is present before retrieving the particular key in the dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.