Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out non-printable characters read from syseeprom #17

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

rajendra-dendukuri
Copy link
Collaborator

Added defensive code to check for printable characters in the output of decode-syseeprom command.

Fixes #15

Signed-off-by: Rajendra Dendukuri rajendra.dendukuri@broadcom.com

Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
@rajendra-dendukuri
Copy link
Collaborator Author

@xumia Can you please help me with the check failure that I am seeing. This is the first PR that I am pushing after Azure/sonic-build-tools#84 is merged.

@liat-grozovik
Copy link

retest buster please

@liat-grozovik
Copy link

retest this please

1 similar comment
@lguohan
Copy link
Contributor

lguohan commented Jun 25, 2020

retest this please

@lguohan lguohan merged commit 5af8c95 into sonic-net:master Jun 25, 2020
rajendra-dendukuri added a commit that referenced this pull request Jul 6, 2020
Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 7, 2020
qiluo-msft pushed a commit that referenced this pull request Sep 23, 2020
* [MultiDB] Add multidb support to sonic-ztp
* Hide stray output message while removing ZTP config
* Filter out non-printable characters read from syseeprom (#17)
* Update all references to new 'sonic-installer' file name
* Update paths to reflect new utilities install location, /usr/local/bin/
* [MultiDB] Add multidb support to sonic-ztp
* Hide stray output message while removing ZTP config
* Fix additional review comments
* Remove duplicate configdb connector creation
* Remove references to host address while creating a DB connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZTP Error (1) encountered while processing the command curl
3 participants