-
-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to locally preferred ruby when running from user's home #1011
Conversation
I suspect that this patch solves these users' bug reports:
...and similar. |
Wonderful! It fixes my problem. (I suspect #918 could also be closed because of recent changes, too). |
Fallback to locally preferred ruby when running from user's home
Thanks! I think the extra feedback will be very useful for future debugging... |
Hi @hzulla! The last commit adding errors to core.rb made me realize that the ruby_gem_api_path points to for instance: rb-native/windows/2.1.0/ Thanks! |
native/windows/ruby is the directory of Sonic Pi's own copy of ruby on Windows. The other directory is the location of the Sonic Pi specific gems. The patch shouldn't have changed that. |
I see.. I dont have this directory though. It seems my gems are stored in native/windows/ruby/lib/ruby/gems. |
The location of the Sonic Pi gems has been changed back in November: #846 |
Ok, as discovered by @rbnpi and @JeroennC , this line breaks the Windows install of Sonic Pi at the moment because the Windows distribution uses a different directory layout. @jweather - you're in charge of the Windows package. What's your opinion on this? Do you want to move the gems to |
Let's keep the current structure, it's fragile enough as it is. |
ruby, how shall I call thee?
Oh, multifaceted beast of a dozen install locations, what is thy name?
So, #835 seemed like a good idea at the time, but maybe it's better to only use the system's
/usr/bin/ruby
when Sonic Pi is actually installed in/opt/
(Rasbpian) or in/usr/bin/
(normal Linux).Otherwise, the user probably expects to use the preferred ruby in the current path settings.
This should help fix the issues reported by users who had their own rvm ruby installed locally.
The most problematic part of this patch may be that it falls back to "ruby" on all platforms, not just on Raspberry as previously. I guess that this would help with users on OS X compiling their own Sonic Pi on their box, but this needs to be discussed prior to merging.