feat: ijekavica demo #200
Open
feat: ijekavica demo #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
commented
Feb 13, 2022
| @@ -79,8 +79,8 @@ export interface ITableData { | |||
|
|
|||
| export const tablesData: ITableData[] = [ | |||
| { | |||
| spreadsheetId: '1N79e_yVHDo-d026HljueuKJlAAdeELAiPzdFzdBuKbY', | |||
| sheetId: '1987833874', | |||
| spreadsheetId: '11TEUKt52TXnLbCvUWzSFK7zzDOzqsyHKw7dt2iZ0dD8', | |||
There was a problem hiding this comment.
For demo purpose.
noomorph
commented
Feb 13, 2022
| break; | ||
| } | ||
|
|
||
| this.splittedMap[lang].set(id, splittedField); | ||
| if (lang === 'sr') { |
There was a problem hiding this comment.
Blatant hardcode... but I need to make sure we remove those нагове̖штавање, нагове̖штај from the visual results.
noomorph
commented
Feb 13, 2022
| @@ -21,6 +23,12 @@ loadTablesData.then(({ data, columns }) => { | |||
| columns.forEach((column: string[]) => { | |||
| const fieldName = getColumnName(column); | |||
|
|
|||
| if (fieldName === 'sr') { | |||
There was a problem hiding this comment.
Again some blatant hardcode... but I need to make sure we remove those нагове̖штавање, нагове̖штај from the visual results.
noomorph
commented
Feb 13, 2022
| "scripthost", | ||
| "es2015.collection" | ||
| "es2015", | ||
| "es2019.array" |
There was a problem hiding this comment.
One more thing, do we have autopolyfilling for latest browsers > 0.5%? Should I worry about using Array.prototype.flatMap, @sonic16x ?
Pull Request Test Coverage Report for Build 1887839461
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for Ekavian/Ijekavian search in Serbian.
Code
Ekavica:
Ijekavica:
Sheets
App
WDYT, @sonic16x , @ru-danko ?
Any ideas on how to rewrite a couple of hardcoded places?