feat: Connor the bot #1227
Merged
feat: Connor the bot #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikonov1101
requested review from
3Hren,
antmat,
zavgorodnii and
a team
as code owners
nikonov1101
force-pushed
the
feat/connor-v2
branch
from
e584ccd
to
b1a8a6f
Compare
nikonov1101
force-pushed
the
feat/connor-v2
branch
3 times, most recently
from
8600434
to
f71d78f
Compare
3Hren
requested changes
Aug 1, 2018
Makefile
Outdated
| @@ -112,9 +113,13 @@ build/oracle: | |||
| @echo "+ $@" | |||
| ${GO} build -tags "$(TAGS)" -ldflags "$(LDFLAGS)" -o ${ORACLE} ${GOCMD}/oracle | |||
|
|
|||
| build/connor: | |||
| @echo "+ $@" | |||
| ${GO} build -tags "$(TAGS)" -ldflags "$(LDFLAGS)" -o ${CONNOR} ${GOCMD}/connor_v2 | |||
nikonov1101
force-pushed
the
feat/connor-v2
branch
3 times, most recently
from
bea5e00
to
d2d5888
Compare
nikonov1101
added
T: feature
3Hren
requested changes
Aug 2, 2018
connor/antifraud/antifraud.go
Outdated
| } | ||
|
|
||
| func lifeTime(deal *sonm.Deal) time.Duration { | ||
| return time.Now().Sub(deal.GetStartTime().Unix()) |
connor/antifraud/antifraud.go
Outdated
| } | ||
|
|
||
| type antiFraud struct { | ||
| mu sync.RWMutex |
There was a problem hiding this comment.
Either describe or put the mutex near variables it protects.
| blacklistWatchers: map[common.Address]*blacklistWatcher{}, | ||
| nodeConnection: nodeConnection, | ||
| deals: sonm.NewDealManagementClient(nodeConnection), | ||
| log: log, |
There was a problem hiding this comment.
I'd rather use sugared logger instead of garbaging attributes space.
connor/antifraud/antifraud.go
Outdated
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return nil |
There was a problem hiding this comment.
Is there a reason not to return ctx.Err()?
connor/antifraud/antifraud.go
Outdated
| log.Warn("task quality is less that required, closing deal", | ||
| zap.Float64("calculated", qualityByLogs), zap.Float64("required", m.cfg.TaskQuality)) | ||
|
|
||
| if err := m.finishDeal(dealMeta.deal, sonm.BlacklistType_BLACKLIST_WORKER); err != nil { |
There was a problem hiding this comment.
It's potentially long-running method, but the mutex is held.
connor/antifraud/pool_processor.go
Outdated
| } | ||
|
|
||
| func (w *dwarfPoolWatcher) TaskQuality() (bool, float64) { | ||
| accurate := w.startTime.Add(10 * time.Minute).Before(time.Now()) |
connor/antifraud/pool_processor.go
Outdated
| } | ||
|
|
||
| func (w *dwarfPoolWatcher) watch() error { | ||
| url := fmt.Sprintf("http://dwarfpool.com/eth/api?wallet=%s", strings.ToLower(w.wallet.Hex())) |
|
|
||
| type engine struct { | ||
| log *zap.Logger | ||
| ctx context.Context |
connor/engine.go
Outdated
| if ord.GetOrderStatus() == sonm.OrderStatus_ORDER_INACTIVE { | ||
| log.Info("order becomes inactive, looking for related deal") | ||
|
|
||
| if ord.GetDealID() == nil || ord.GetDealID().IsZero() { |
There was a problem hiding this comment.
Checking for ord.GetDealID() == nil is redundant.
| } | ||
|
|
||
| func (p *nullPriceProvider) GetPrice() *big.Int { | ||
| v, _ := big.NewFloat(0).Mul(big.NewFloat(5e5), big.NewFloat(p.cfg.Margin)).Int(nil) |
nikonov1101
force-pushed
the
feat/connor-v2
branch
4 times, most recently
from
63630b6
to
79b1778
Compare
This commit introduces Connor, the bot which buying resources for mining. The current implementation can: - Places BID orders according to config. - Restores orders, deals, and tasks between restarts. - Loads actual price of the target token, create orders according to price and marginality coefficient. - Tracks token price changes using CoinMarketCap, re-create orders if the price changed sufficiently. - Looks for actual hashrate by logs and mining pool statistics. - Closes deals which give us less hash-rate than offered. Note that current implementation is strongly coupled with the Ethereum mining on the DwarfPool. Next, we'll make it more modular and configurable for other popular tokens and pools.
nikonov1101
force-pushed
the
feat/connor-v2
branch
from
79b1778
to
cd4c897
Compare
3Hren
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces Connor, the bot which buying resources
for mining. The current implementation can:
Note that current implementation is strongly coupled with the Ethereum mining on the DwarfPool.
Next, we'll make it more modular and configurable for other popular tokens and pools.