Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preventing division by zero panics #1852

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Preventing division by zero panics #1852

merged 1 commit into from
Feb 8, 2019

Conversation

mou
Copy link
Contributor

@mou mou commented Feb 7, 2019

Closes #1851

nikonov1101
nikonov1101 approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@nikonov1101 nikonov1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid else in that case - uint64 type has already been initialized with zero value.

@nikonov1101 nikonov1101 merged commit e192b69 into master Feb 8, 2019
@nikonov1101 nikonov1101 deleted the fix/sonmmon/status-division-by-zero branch February 8, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikonov1101 nikonov1101 nikonov1101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mou @nikonov1101