fix: price validations during proposing deal #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - Cmp for `sonm.Price`. Changed: - Use PricePerSecond field in order. Note: deprecated `Order` field is left for backward compatibility to ease migration process with other contributors. - Removed no longer used code. Fixed: - Price validations during and after proposing a deal.
3Hren
force-pushed
the
fix/propose-deal
branch
from
3ddc388
to
5911adc
Compare
nikonov1101
approved these changes
Dec 26, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
sonm.Price.Changed:
Orderfield is left for backward compatibility to ease migration process with other contributors.Fixed: