Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/hw logs #385

Merged
merged 5 commits into from
Jan 16, 2018
Merged

Fix/hw logs #385

merged 5 commits into from
Jan 16, 2018

Conversation

nikonov1101
Copy link
Member

Added:

  • log error if the worker cannot collect GPU info
  • log collected hardware on worker's start

Fixed:

  • handler error if NewMiner has failed

Outofscope:

  • lowercase logs is awesome;
  • do not clash variables and import names;

@nikonov1101 nikonov1101 requested a review from a team January 16, 2018 10:02
sokel
sokel previously approved these changes Jan 16, 2018
View reviewed changes
3Hren
3Hren requested changes Jan 16, 2018
View reviewed changes
insonmnia/hardware/hardware.go Outdated
@@ -83,6 +88,7 @@ func (h *hardwareInfo) Info() (*Hardware, error) {

gpuInfo, err := h.GPU()
if err != nil {
log.G(h.ctx).Warn("cannot get GPU devices list", zap.Error(err))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return error instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fucking awesome yeah

insonmnia/hardware/hardware.go Outdated
@@ -56,6 +60,7 @@ type HardwareInfo interface {
}

type hardwareInfo struct {
ctx context.Context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this if we'll return on failed GPU fetching.

@3Hren 3Hren merged commit cd60e0b into master Jan 16, 2018
@3Hren 3Hren deleted the fix/hw-logs branch January 16, 2018 19:54
@3Hren 3Hren mentioned this pull request Feb 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zavgorodnii zavgorodnii zavgorodnii left review comments

@3Hren 3Hren 3Hren approved these changes

@sokel sokel sokel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikonov1101 @3Hren @sokel @zavgorodnii