Feature: extended deal info #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikonov1101
force-pushed
the
feature/extend-deal-info
branch
2 times, most recently
from
c4bd427
to
90e48df
Compare
3Hren
reviewed
Jan 17, 2018
insonmnia/hub/server.go
Outdated
| h.deleteTask(task.ID) | ||
| err = h.deleteTask(task.ID) | ||
| if err != nil { | ||
| log.G(ctx).Warn("cannot delete task", zap.Error(err)) |
There was a problem hiding this comment.
Error, because we break the request on this.
insonmnia/hub/server.go
Outdated
| taskDetails, err := mctx.Client.TaskDetails(ctx, &pb.ID{Id: t.ID}) | ||
| if err != nil { | ||
| log.G(h.ctx).Warn("cannot get task status", | ||
| zap.String("worker_id", t.MinerId), zap.String("task_id", t.ID), zap.Error(err)) |
There was a problem hiding this comment.
I thought we use camelCase in log attribute names.
nikonov1101
force-pushed
the
feature/extend-deal-info
branch
from
90e48df
to
1e64826
Compare
nikonov1101
force-pushed
the
feature/extend-deal-info
branch
from
1e64826
to
946a868
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deal statushandle now can show extended info, that fetched from the Hub.If a Deal was not accepted (there is no info about the Hub) - show only a Deal info (previous behavior)
If the Hub is associated with a Deal - the Node will try to connect to the Hub and retrieve the details (resources from the Order, running tasks, finished tasks)
BTW:
dealInfostruct became unused and was removed;hub.deleteTask(id)was added;