-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show error about balance if there is no balance #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really familiar with the code, but:
- orderLoop is very big for understanding
- you iterate via orders, but if there is no balance for the FIRST order you break the loop. Looks like improper behaviour.
I might be wrong, but please add some explanation for this PR
de88363
to
ab68169
Compare
@antmat You are right about the first item, that breaks the loop, thanks! filter orders by balance and allowance to prevent dealing with too expensive orders is added. |
ab68169
to
2794c47
Compare
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 18.18% 18.45% +0.26%
==========================================
Files 88 90 +2
Lines 9459 9560 +101
==========================================
+ Hits 1720 1764 +44
- Misses 7554 7608 +54
- Partials 185 188 +3
Continue to review full report at Codecov.
|
82b2b28
to
2794c47
Compare
2794c47
to
2a29f83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still orderLoop is very hard to understand, but this paerticular PR is clear and LGTM
No description provided.