Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error about balance if there is no balance #398

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Conversation

nikonov1101
Copy link
Member

No description provided.

@nikonov1101 nikonov1101 requested a review from a team January 18, 2018 16:02
Copy link
Collaborator

@antmat antmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with the code, but:

  • orderLoop is very big for understanding
  • you iterate via orders, but if there is no balance for the FIRST order you break the loop. Looks like improper behaviour.
    I might be wrong, but please add some explanation for this PR

@nikonov1101
Copy link
Member Author

@antmat You are right about the first item, that breaks the loop, thanks!

filter orders by balance and allowance to prevent dealing with too expensive orders is added.

@codecov-io
Copy link

codecov-io commented Jan 23, 2018

Codecov Report

Merging #398 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   18.18%   18.45%   +0.26%     
==========================================
  Files          88       90       +2     
  Lines        9459     9560     +101     
==========================================
+ Hits         1720     1764      +44     
- Misses       7554     7608      +54     
- Partials      185      188       +3
Impacted Files Coverage Δ
insonmnia/node/market.go 66.47% <100%> (+1.41%) ⬆️
fusrodah/hub/server.go 44.11% <0%> (ø)
fusrodah/miner/server.go 28.3% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97af698...2a29f83. Read the comment docs.

Copy link
Collaborator

@antmat antmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still orderLoop is very hard to understand, but this paerticular PR is clear and LGTM

@antmat antmat merged commit d5fb896 into master Jan 23, 2018
@nikonov1101 nikonov1101 deleted the fix/DEV-311 branch January 26, 2018 08:52
@3Hren 3Hren mentioned this pull request Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants