-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Add WebView entry #299
Conversation
That sounds like a good idea. Another idea, if possible, is to demonstrate interacting with the WebView by adding the text & link for the API that way. |
I would prefer the WebView to be immediately available (and load https://gnome.org) so there is no extra step.
It doesn't have to be this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Just a couple of things
const button_stop = workbench.builder.get_object("button_stop"); | ||
const url_bar = workbench.builder.get_object("url_bar"); | ||
const web_view = new WebKit.WebView({ | ||
zoom_level: 0.8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any particular reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it was because you couldn't really see much of the webpage because the view is small, so I decreased the zoom level. It also gave me a reason to show the property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting find. I can confirm it's the same with Box
and append
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
I figured the reason why the webview cannot be created from Blueprint. It's a bug in Workbench, I will fix it and adjust the demo.
Add WebView Entry
Closes #276
Also I would like to know, where should I include the status page for this demo - title, description, links etc. Since the webview takes up the entire window. I was thinking initially when the demo loads, we show the status page in the window and when a link is entered, the webview is shown. Wdyt?