Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: Add Animation entry #306

Merged
merged 5 commits into from
Jun 14, 2023
Merged

library: Add Animation entry #306

merged 5 commits into from
Jun 14, 2023

Conversation

AkshayWarrier
Copy link
Contributor

Closes #284

@AkshayWarrier AkshayWarrier marked this pull request as draft June 7, 2023 19:40
@AkshayWarrier AkshayWarrier marked this pull request as ready for review June 8, 2023 11:26
andyholmes
andyholmes requested changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent demo, especially the concise use of code comments to help the reader.

Just a few superficial changes and it LGTM.

src/Library/demos/Animation/main.css Outdated Show resolved Hide resolved
src/Library/demos/Animation/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Animation/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Animation/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Animation/main.blp Outdated Show resolved Hide resolved
andyholmes
andyholmes approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyholmes andyholmes merged commit 36bc2ee into main Jun 14, 2023
@AkshayWarrier AkshayWarrier deleted the akshaywarrier/animation branch June 14, 2023 07:23
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
@AkshayWarrier @sonnyp
library: Add Animation entry (#306)
cea863c 
* library: Add AdwAnimation entry
* Animation: Fix CallbackAnimationTarget and add AnimationTarget example
* Animation: Add links
* Animation: Changes from review
* Animation: Update main.css
sonnyp pushed a commit that referenced this pull request Jun 20, 2023
@AkshayWarrier @sonnyp
library: Add Animation entry (#306)
39740a9 
* library: Add AdwAnimation entry
* Animation: Fix CallbackAnimationTarget and add AnimationTarget example
* Animation: Add links
* Animation: Changes from review
* Animation: Update main.css
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
@AkshayWarrier @sonnyp
library: Add Animation entry (workbenchdev#306)
27ad35e 
* library: Add AdwAnimation entry
* Animation: Fix CallbackAnimationTarget and add AnimationTarget example
* Animation: Add links
* Animation: Changes from review
* Animation: Update main.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyholmes andyholmes andyholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adw Animation
2 participants
@AkshayWarrier @andyholmes