library: Update Progress Bar demo #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
requested changes
Jun 14, 2023
|
Also, the animation progress bar and the pulse progress bar are not completely synchronized because of the way setInterval works. |
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
* library: Update Progress Bar demo * Progress Bar: Reset the pulse progress bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322
I haven't made any changes to the UI, and I didn't add another progress bar that makes use of setInterval because to pulse the progress bar I'm making use of a setInterval anyway.