Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Add libshumate entry #357

Merged
merged 4 commits into from
Jun 28, 2023
Merged

library: Add libshumate entry #357

merged 4 commits into from
Jun 28, 2023

Conversation

AkshayWarrier
Copy link
Contributor

Closes #349
I have added some basic controls to the demo. But I think adding PathLayer will probably make the demo more complex considering how much code is already there. We could make follow-up to this if we find that PathLayer is an important class to demonstrate.

Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review/iteration

image

This is confusing.

Let's separate the 2 things

  1. Longitude / latitude "Go" (probably it should zoom too)
  2. Place a marker

re.sonny.Workbench.Devel.json Outdated Show resolved Hide resolved
src/Library/demos/Map/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Map/main.json Outdated Show resolved Hide resolved
src/Library/demos/Map/main.js Outdated Show resolved Hide resolved
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 👍

@sonnyp sonnyp merged commit 30f2a46 into main Jun 28, 2023
@sonnyp sonnyp deleted the akshaywarrier/libshumate branch June 28, 2023 14:39
sonnyp pushed a commit that referenced this pull request Jun 29, 2023
sonnyp pushed a commit that referenced this pull request Jul 5, 2023
sonnyp pushed a commit that referenced this pull request Jul 5, 2023
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library entry for map / libshumate
2 participants