library: Add Memory Monitor entry #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
pushed a commit
that referenced
this pull request
Aug 19, 2023
* library: Add Memory Monitor entry * Update main.json * Update main.blp * Memory Monitor: Suggestions
pwithnall
reviewed
Aug 19, 2023
| // Processes should free up unneeded resources | ||
| console.log("Warning Level: Low"); | ||
| drop_caches(); | ||
| } else if (level >= Gio.MemoryMonitorWarningLevel.MEDIUM) { |
There was a problem hiding this comment.
This example is great overall! One comment: this should perhaps be a separate if rather than an else if, otherwise drop_caches() will only be called on levels between LOW and MEDIUM, rather than on all levels >= LOW.
There was a problem hiding this comment.
Actually wait, now that I think about it, won't it behave in a completely oppositive manner? For all levels >= LOW, the first if condition would always be satisfied and it would never get to the other else if(s) even if level >= MEDIUM. I can't believe I missed this but still changing the else if to if should fix the issue regardless.
sonnyp
pushed a commit
that referenced
this pull request
Aug 20, 2023
* library: Add Memory Monitor entry * Update main.json * Update main.blp * Memory Monitor: Suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #455