Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with the newest version of CocoaPods #63

Merged
merged 2 commits into from
Jan 21, 2015
Merged

Build with the newest version of CocoaPods #63

merged 2 commits into from
Jan 21, 2015

Conversation

keith
Copy link
Contributor

@keith keith commented Jan 21, 2015

  • Update the pods (depends on Update podspecs for new CocoaPods Podspecs#5) just enough to build sonora. Can probably update some other stuff (like AFNetworking)
  • Specify podspec sources so new builds don't have to manually clone https://github.com/sonoramac/Podspecs
  • Check in Podfile.lock no pods won't be updated unless explicitly running pod update
  • Move submodule to the supported Sparkle branch (I didn't do extensive testing here but it builds successfully)
  • It seems like mogenerator had some churn here.

The only other thing I had to do to build sonora was deal with some macro definitions from SFBAudioEngine. I'm not sure how to handle that long term.

@indragiek
Copy link
Member

This looks good to me 👍 . What was the issue with the macro definitions?

@keith
Copy link
Contributor Author

keith commented Jan 21, 2015

screen shot 2015-01-21 at 11 39 10

All of the pictured build errors are the same as this one. Just putting the space there fixes those errors but I'm not sure what ramifications that has. Also I imagine there's a build setting that could be specified to disable this, which would be idea.

@keith
Copy link
Contributor Author

keith commented Jan 21, 2015

Oh actually a few of those errors are fixed by explicitly adding:

@synthesize appearance = _appearance;

To MASShortCutView.m

@indragiek
Copy link
Member

For the SFBAudioEngine errors, the linked frameworks archive in the README is old. There's a new version available from the main SFBAudioEngine repo, direct link:

http://files.sbooth.org/SFBAudioEngine-dependencies.tar.bz2

If you replace the old libraries with these versions, are the errors fixed?

@indragiek
Copy link
Member

Or, as you said, there should be a build setting to disable that error. Some googling lead to -Wliteral-suffix being the likely culprit.

@keith
Copy link
Contributor Author

keith commented Jan 21, 2015

I just pushed a commit to bump MASShortcut to 1.3.1. I built it with 2.0.1 as well and everything seemed fine, but this seems safer. Related to sonoramac/Podspecs#6

@keith
Copy link
Contributor Author

keith commented Jan 21, 2015

Looks like these new dependencies have a very different folder structure:
screen shot 2015-01-21 at 11 46 37

@keith
Copy link
Contributor Author

keith commented Jan 21, 2015

I've tried -Wliteral-suffix and -Wno-literal-suffix and can't seem to make them work.

@keith
Copy link
Contributor Author

keith commented Jan 21, 2015

@indragiek
Copy link
Member

I guess manually editing the macros is the workaround for now :/ Looks great otherwise, thanks again!

indragiek added a commit that referenced this pull request Jan 21, 2015
Build with the newest version of CocoaPods
@indragiek indragiek merged commit 64e842b into sonoramac:master Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants