Use package name instead of runnable id for dir on target #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means means multiple runnables from the same package (ie integration tests) will live in the same directory on the target device and this directory will be stable and will not contain a build hash. This is way better for disk usage especially when lots for tests resources need to be copied (as those will not be duplicated on the target device). This should also improve the first execution time on ssh devices when there are multiple integration tests in the package as the resources will need to only be copied once then rsync will do some magic
kali
approved these changes
Jul 20, 2022
fredszaq
deleted the
use-package-name-instead-of-runnable-id-for-dinghy-dir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means means multiple runnables from the same package (ie
integration tests) will live in the same directory on the target device
and this directory will be stable and will not contain a build hash.
This is way better for disk usage especially when lots for tests
resources need to be copied (as those will not be duplicated on the
target device). This should also improve the first execution time on ssh
devices when there are multiple integration tests in the package as the
resources will need to only be copied once then rsync will do some magic