Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue after update to flutter 3.13.0 #205

Closed
jvieira88 opened this issue Aug 17, 2023 · 7 comments
Closed

Issue after update to flutter 3.13.0 #205

jvieira88 opened this issue Aug 17, 2023 · 7 comments

Comments

@jvieira88
Copy link

Hi,

There seems to be an issue after the flutter update to 3.13.0 (#204). Just had a quick look but it seems to affect some widgets such as the DropdownButton and other buttons. I reverted back to #201 and it seems fine.

Example with #204
image

Example with #201:
image

Maybe it's not related with flutter-elinux but just thought to bring it up.

@HidenoriMatsubayashi
Copy link
Collaborator

Sorry, what is your issue?

@HidenoriMatsubayashi
Copy link
Collaborator

HidenoriMatsubayashi commented Aug 17, 2023

The following template source files were updated in flutter 3.13.0.

Can you check if the files you are using are up to date? They can be found in <path_to_your_flutter_project>/elinux directory.

HidenoriMatsubayashi added a commit to HidenoriMatsubayashi/flutter-embedded-linux that referenced this issue Aug 18, 2023
Disable vsync waiter as it may be causing rendering issues.

Related issue (maybe) sony/flutter-elinux#205

Signed-off-by: Hidenori Matsubayashi <Hidenori.Matsubayashi@gmail.com>
@HidenoriMatsubayashi
Copy link
Collaborator

HidenoriMatsubayashi commented Aug 18, 2023

@jvieira88
Can you please check if this issue occurs on elinux-x11 backend too?

$ flutter-elinux run -d elinux-x11

The root cause might be sony/flutter-embedded-linux#376.

HidenoriMatsubayashi added a commit to HidenoriMatsubayashi/flutter-embedded-linux that referenced this issue Aug 18, 2023
Disable vsync waiter as it may be causing rendering issues.

Related issue (maybe) sony/flutter-elinux#205

Signed-off-by: Hidenori Matsubayashi <Hidenori.Matsubayashi@gmail.com>
HidenoriMatsubayashi added a commit to sony/flutter-embedded-linux that referenced this issue Aug 18, 2023
Disable vsync waiter as it may be causing rendering issues.

Related issue (maybe) sony/flutter-elinux#205

Signed-off-by: Hidenori Matsubayashi <Hidenori.Matsubayashi@gmail.com>
@HidenoriMatsubayashi HidenoriMatsubayashi added the bug Something isn't working label Aug 18, 2023
@jvieira88
Copy link
Author

Hi @HidenoriMatsubayashi,

Running with X11 results in the same issue.
However, both main.cc and flutter_embedder_options.h local to the project (under /elinux/runner/) differ from the source files you mentioned. Is there a way of refreshing these local files without having to manually execute a run command every time there is an update?

@HidenoriMatsubayashi
Copy link
Collaborator

However, both main.cc and flutter_embedder_options.h local to the project (under /elinux/runner/) differ from the source files you mentioned.

Okay. So please try #205 (comment).

Is there a way of refreshing these local files without having to manually execute a run command every time there is an update?

Unfortunately, there is no way to upgrade local elinux c++ files in existing projects. Please replace your local files manually.

@jvieira88
Copy link
Author

I confirm that it's all working fine with both wayland and X11 after copying the files from /flutter-elinux/templates/app/runner to the project /elinux/runner local folder. Something to keep in mind the next time I need to update the repository :)

@HidenoriMatsubayashi HidenoriMatsubayashi removed the bug Something isn't working label Aug 21, 2023
@HidenoriMatsubayashi
Copy link
Collaborator

Great.

Something to keep in mind the next time I need to update the repository :)

I'll consider automatic-migration way in flutter-elinux.

Closing. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants