platform: Wrap the WIFI_DRIVER_STATE_ON and WIFI_DRIVER_STATE_OFF val… #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues in quotations
Fixes the below compilation error on android 14 : frameworks/opt/net/wifi/libwifi_hal/wifi_hal_common.cpp:194:7: error: no matching function for call to 'wifi_change_driver_state'
if (wifi_change_driver_state(WIFI_DRIVER_STATE_ON) < 0) {
jerpelea
approved these changes
Oct 26, 2023
|
Is this just bad forwarding of the parameters to the build system? Or is there an upstream change (that we should cherry-pick) that does the same? |
|
@ShujathMohd the same change is needed on all platforms (lena, murray, nagara, sagami, seine, yodo, zambezi) |
|
I wonder if we should backport this, perhaps we were always passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ues in quotations
Fixes the below compilation error on android 14 : frameworks/opt/net/wifi/libwifi_hal/wifi_hal_common.cpp:194:7: error: no matching function for call to 'wifi_change_driver_state' if (wifi_change_driver_state(WIFI_DRIVER_STATE_ON) < 0) {