github: simplify getting PR merge status #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`merged_at` is `null` if the PR is either open, or closed unmerged. Not 100% certain that field is guaranteed to be populated for *every* PR on GitHub, regardless of age, but I think it's acceptable to get rid of the second API request in exchange for a small risk of giving slightly incorrect output in a very small number of cases.
dgw
added a commit
that referenced
this pull request
Apr 17, 2023
This accepts `user/reponame#123` in all cases. As before, if the current channel has a default repo (set using the `.gh-repo` command), `#123` will be treated as a reference to an issue or PR in the configured default repo. Additionally, `reponame#123` will now fill in the missing "username" portion from the configured default. Implementing this feature required switching to named capture groups in all URL patterns, because the `user` and `reponame` portions of the inline references are optional. It seemed like a maintainability win, anyway, so even if I just missed thinking of a way to do it with numbered capture groups, I'm glad to have made the change anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged_atisnullif the PR is either open, or closed unmerged.Not 100% certain that field is guaranteed to be populated for every PR on GitHub, regardless of age, but I think it's acceptable to get rid of the second API request in exchange for a small risk of giving slightly incorrect output in a very small number of cases.