Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: include issue/PR state in issue_info() #87

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

dgw
Copy link
Member

@dgw dgw commented Feb 27, 2021

Fetches the Pull endpoint if the referenced issue is a pull request AND ALSO has the 'closed' state, to check if it was merged.

Closes #86.

Example:

<Old> [GitHub] [sopel-irc/sopel #2020] half-duplex: logging: don't crash if backend is uninitialized | When
      `core.logging_channel` is used, errors early in startup cause an exception that halts the bot.
      (bdc10e0, current master) […]
<New> [GitHub] [sopel-irc/sopel #2020] merged PR by half-duplex: logging: don't crash if backend is
      uninitialized | When `core.logging_channel` is used, errors early in startup cause an exception that
      halts the bot. (bdc10e0, current master) […]

@half-duplex I like this style better than adding more brackets. What say you?

@dgw dgw added this to the 0.4.2 milestone Feb 27, 2021
@half-duplex
Copy link
Member

No strong preference on sentence vs brackets, main goal is just having the info there. Thank you!

Fetches the Pull endpoint if the referenced issue is a pull request AND
ALSO has the 'closed' state, to check if it was merged.

Co-authored-by: mal <mal@sec.gd>
@dgw dgw merged commit 4120bfc into master Jun 2, 2021
@dgw dgw deleted the 86-issue-open-closed branch June 2, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue/PR info should include closed/open/merged status
2 participants