Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instagram: catch parse errors #1702

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Oct 8, 2019

Sometimes Instagram doesn't expose its payload: probably some loading errors or something alike. Since we can't do anything about it - usually all you can do is retry later - the bot now say so (and log an exception).

This fix #1667

@Exirel Exirel added Tweak Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Oct 8, 2019
@Exirel Exirel added this to the 7.0.0 milestone Oct 8, 2019
@Exirel Exirel requested a review from a team October 8, 2019 22:03
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo-fixing brigade! (Mostly.)

sopel/modules/instagram.py Outdated Show resolved Hide resolved
sopel/modules/instagram.py Show resolved Hide resolved
sopel/modules/instagram.py Outdated Show resolved Hide resolved
sopel/modules/instagram.py Outdated Show resolved Hide resolved
Sometimes Instagram doesn't expose its payload: probably some loading
errors or something alike. Since we can't do anything about it - usually
all you can do is retry later - the bot now say so (and log an
exception).

This fix sopel-irc#1667

Co-Authored-By: dgw <dgw@technobabbl.es>
@Exirel
Copy link
Contributor Author

Exirel commented Oct 9, 2019

@dgw changes applied, string length fixed, all squashed for good measure.

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

@dgw dgw merged commit 33c153b into sopel-irc:master Nov 11, 2019
@dgw dgw removed the request for review from a team November 11, 2019 19:29
@Exirel Exirel deleted the instagram-catch-errors branch January 14, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instagram URL sometimes shows KeyError
2 participants