reddit: media details (+ refactoring) #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
approved these changes
Nov 5, 2019
Fetches the canonical post for videos by asking Reddit for a redirect (cheeky hack) and shows normal post details for that. Fetches the oldest post for a linked image via searching r/all and shows the usual info about that submission. Cheeky hack for getting a video's canonical URL designed by committee on Sopel's IRC channel. (See co-authors.) Co-Authored-By: deathbybandaid <sam@deathbybandaid.net> Co-Authored-By: Exirel <florian.strzelecki@gmail.com> Co-Authored-By: kwaaak <kwaaak@users.noreply.github.com>
dgw
force-pushed
the
reddit-media-details
branch
from
590c894
to
f6d79ae
Compare
This is *much* better than repeating the construction call everywhere, & more efficient than making a new instance every time we're triggered.
Instead of forcing every handler that might want to trigger output of information about a post (submission) to twist its variables around so they'll work for a function designed to act on links posted in the chat, it's much better to have a separate output function that takes just the ID of a submission, and fetches/displays the details on its own. This way, no matter what another function is trying to match (Reddit-hosted images, video links, etc.), all it has to do is pass along the submission ID -- however it gets that.
dgw
force-pushed
the
reddit-media-details
branch
from
f6d79ae
to
d6f26b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary changes: The
redditplugin now understands how to detect links to images & videos hosted by Reddit itself (i.redd.itandv.redd.itURLs), and how to map those back to a submission. For images, it's the oldest submission with that link as the URL; for videos, Reddit itself redirects the short URL to a 'canonical' post (should be the first, excluding all crossposts).Secondary changes: Enough with the
praw.Reddit()setup being duplicated, and enough with constructing a new instance every time the plugin wants to do something. Now, it constructs just one PRAW instance at load time, and stores it in Sopel's memory for reuse.Tertiary changes:
rpost_info()is now Just Another URL Detector™, like the newly added media link handlers. All of them now pass just the desired submission ID to a newsay_post_info()function, leaving only the route to getting the desired ID for the triggerable functions.Concerns: Potential conflicts with the changes #1722. We'll figure that out later, if necessary.