Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: fix/update python version checks #1795

Merged
merged 1 commit into from
Jan 6, 2020
Merged

setup: fix/update python version checks #1795

merged 1 commit into from
Jan 6, 2020

Conversation

half-duplex
Copy link
Member

The check for python 3.3+ was broken, and python 2's last maintenance release is now scheduled for "mid-april" 2020.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No (related) issues are reported by make qa
  • I have tested the functionality of the things this change touches

@half-duplex
setup: fix/update python version checks
c18ee81 
Python 2's last maintenance release is now scheduled for "mid-april"
@half-duplex half-duplex added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Dec 30, 2019
@half-duplex half-duplex added this to the 7.0.0 milestone Dec 30, 2019
@half-duplex
Copy link
Member Author

Actually, what case is the manual python version check necessary in? python sopel.py wouldn't hit it, and any pip or setuptools installation should hit the python_requires.

dgw
dgw approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm amused that you bothered updating the "RTGDMFM" comment. Hopefully I can get CI to pass this. (Edit: I did, with no effort beyond clicking "Restart build".)

@dgw dgw merged commit fede807 into sopel-irc:master Jan 6, 2020
@half-duplex half-duplex deleted the py-version-detection branch January 6, 2020 08:39
@half-duplex half-duplex restored the py-version-detection branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@half-duplex @dgw