This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
add test for modules in modules #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaahc
force-pushed
the
module-in-module
branch
2 times, most recently
from
728db10
to
178b13b
Compare
yaahc
commented
Feb 23, 2024
yaahc
force-pushed
the
module-in-module
branch
from
178b13b
to
3bcaa38
Compare
yaahc
commented
Feb 23, 2024
yaahc
force-pushed
the
module-in-module
branch
7 times, most recently
from
c71399c
to
b2bb9ed
Compare
* Associate call resolution with outermost NodeId for namespaced calls * update codegen to check call resolution on outermost namespaced lookup
yaahc
force-pushed
the
module-in-module
branch
from
b2bb9ed
to
38a7c78
Compare
sophiajt
reviewed
Feb 28, 2024
| use deep2; | ||
|
|
||
| fun main() { | ||
| deep2::deep3::say_hello() |
There was a problem hiding this comment.
For this, I was wondering if we would want deep2 to be a directory we traverse to get to deep3.
Probably worth brainstorming whether files are the only modules or if directories can be too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.