feat: add service_type argument to service create/update #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a service_type argument to
create_service()
andupdate_service()
so that additional service types can be supported.When creating/updating IP services, it is only necessary to specify the protocol as it is shown in the UI. The protocol number is shown in the UI, however it is not used in the API. Similarly, for ICMP the types and codes should be provided using their names as shown in the UI rather than the numbers.
Examples: