Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#51] 모임 게시글 조회 시, 모임 데이터도 response에 추가 #52

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

yeseul106
Copy link
Member

작업 내용

  • v1 모임 게시물 조회 API의 reponse에 meeting 데이터 추가

관련 이슈

#51


/** 모임 이미지 */
@IsNotEmpty()
imageURL: ImageURL[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인터페이스로 정의되어있는 부분을 class로 변경한 다음에 검사하면 어떨까요?

ValidateNested데코레이터와 Type데코레이터, IsInstance 데코레이터를 사용하면 중첩된 구조도 검사가 가능할 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 네 !! 좋은 리뷰 감사드려요 !!! 요 부분 반영하겠습니다 !

@rdd9223
Copy link
Contributor

rdd9223 commented Sep 29, 2023

멋져요!

@yeseul106 yeseul106 merged commit c2316c5 into develop Sep 29, 2023
@mikekks mikekks deleted the feature/#51 branch August 4, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 feature 새로운 기능 size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

모임 게시글 조회 시, 모임에 대한 데이터도 추가로 내려주도록 수정
2 participants