Update activesupport.rbi #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarbs
commented
Nov 3, 2020
| sig do | ||
| params( | ||
| number: T.any(Integer, Float, String), | ||
| number: T.any(Numeric, String), |
There was a problem hiding this comment.
These (and many other sigs) were typed as T.any(Integer, Float) but any Numeric (BigDecimal, Rational) would work.
jeffcarbs
commented
Nov 3, 2020
| sig { params(keys: T.untyped).returns(T.self_type) } | ||
| def except(*keys); end | ||
|
|
||
| sig { returns(T::Hash[String, V]) } |
There was a problem hiding this comment.
symbolize_keys and stringify_keys only operate on the keys so whatever the V is should be unchanged. The other sigs were losing that type information by making them T.untyped.
jeffcarbs
commented
Nov 3, 2020
| @@ -1422,3 +1713,996 @@ module Benchmark | |||
| sig { params(block: T.proc.void).returns(Float) } | |||
| def self.ms(&block); end | |||
| end | |||
|
|
|||
| class ActiveSupport::Cache::Store | |||
There was a problem hiding this comment.
The rest of this file was pulled out of the RBI file generated by tapioca.
jez
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge our (Gusto's) hand-maintained activesupport.rbi with the upstream.