Add a basic gem.rbi to lib/ruby.

[connorshea]

The goal here is to resolve sorbet/sorbet#1455

There are a few problems with this as it is now:

• Almost everything is untyped
• Lots of _ parameters
• This is specifically for RubyGems 3.x
• I'm not sure if gem.rbi should be part of the ruby/ directory or not?
• I'm not sure if gem.rbi should actually be rubygems.rbi?
• Can Sorbet actually determine the user's RubyGems version?
• There may be some minor errors, I generated this with Sord, but I've fixed a few of its quirks manually and generally I think it's been pretty well battle-tested at this point.

Adding this RBI to my sorbet/ directory and then regenerating hidden.rbi drops it down from 7419 lines to 3386 lines.

[connorshea]

Also, this exists already: https://github.com/sorbet/sorbet/blob/719eb639e535860a3f1e3288fed3dcd47586eb5e/rbi/stdlib/gem.rbi

So that's probably a problem

[connorshea]

Any ideas on fixing this last error? 🤔

Connors-MacBook-Pro:sorbet-typed connorshea$ ruby .ci/run.rb 
lib/bundler/all/bundler.rbi:1211: Type Elem declared by parent T.class_of(Gem::Specification) must be re-declared in T.class_of(Bundler::EndpointSpecification) https://srb.help/5036
    1211 |class Bundler::EndpointSpecification < Gem::Specification
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    https://github.com/sorbet/sorbet/tree/719eb639e535860a3f1e3288fed3dcd47586eb5e/rbi/stdlib/gem.rbi#L207: Elem declared in parent here
     207 |class Gem::Specification < Gem::BasicSpecification
                ^^^^^^^^^^^^^^^^^^
Errors: 1

[jez]

@connorshea I would propose removing the autogenerated sigs that have untyped. Putting them there locks in the sigs for everyone else, whereas by omitting them, people can one-off sig individual methods to have better types in the mean time while they're submitting a patch to add proper types upstream.

It'll also make the file smaller, so fewer lines in the sorbet/ folder.

[connorshea]

Removed all the untyped stuff 👍

[elliottt]

It looks like the error with the bundler rbi is due to the bundler.rbi that exists in sorbet https://github.com/sorbet/sorbet/blob/master/rbi/gems/bundler.rbi

[connorshea]

Hmm, why do you think so?

[elliottt]

The build failure for your most recent commit says that you need to declare Elem, but you're already doing that as of a86b6ec.

[connorshea]

Any ideas on how to fix it?

[elliottt]

Did you mean to extend Enumerable here? That's likely what's causing problems with the bundler rbi.

[connorshea]

oh wow, good catch. I'm not entirely sure how that got in there.

[elliottt]

You should also be able to remove the changes to the bundler rbi now.

[connorshea]

👍 done

[elliottt]

Thanks!