ruby27: Reject CSend inside left hand side of mass assign #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tracks upstream commits ruby/ruby@140b811 and ruby/ruby@39ae88a. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
commented
Jul 6, 2020
| @@ -10,6 +10,5 @@ def some_method(array) | |||
| a, b, *c, d, e = array | |||
| a, * = array | |||
| a.x, b = array | |||
| a&.x, b = array | |||
There was a problem hiding this comment.
Not accepted anymore
Morriar
commented
Jul 6, 2020
| @@ -69,20 +69,6 @@ class <emptyTree><<C <root>>> < (::<todo sym>) | |||
| b = <assignTemp>$17.[](1) | |||
| <assignTemp>$16 | |||
| end | |||
| begin | |||
There was a problem hiding this comment.
Not accepted anymore
Morriar
commented
Jul 6, 2020
Comment on lines
+230
to
+232
| if (masgn) { | ||
| error(ruby_parser::dclass::CSendInLHSOfMAsgn, tokLoc(dot)); | ||
| } |
There was a problem hiding this comment.
I feel like it would have been cleaner if done in parser.yyp instead of the Builder but it seems that all the other error cases are always handled in the builder.
If done here, we need to know if the assignation is on a multi left hand side, hence the extra parameter.
There was a problem hiding this comment.
I kind of like your suggestion of inlining this branch into the two cases where masgn is true.
If you'd like to change this, let me know. I'll merge this at the end of the day or whenever you get back to me.
jez
approved these changes
Jul 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Before ruby27, the following snippet will cause
rubyto crash:After ruby27, ruby will return an error instead:
This commit tracks upstream commits ruby/ruby@140b811 and ruby/ruby@39ae88a.
Test plan
See included automated tests.