Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When access ssh for first time, prompt to add fingerprint to known hosts #45

Closed
liza-mae opened this issue Jan 31, 2018 · 6 comments
Closed

Comments

@liza-mae
Copy link

Backport tool uses ssh which prompted me to accept the new fingerprint and add it to my known hosts which paused/waited because stderr/stdout is not properly being displayed.

It should fail or prompt me to accept the fingerprint?

@spalger

@sorenlouv
Copy link
Owner

Hi @liza-mae, thanks for making me aware of this. I just tried to delete my known_hosts file and was able to reproduce the issue, and was getting this error

The authenticity of host 'github.com (192.30.253.113)' can't be established.
RSA key fingerprint is <fingerprint>.

it should also output this part, and wait for user input (but it doesn't)

Are you sure you want to continue connecting (yes/no)?

I was not even considering this case. Is is because you have not before interacted with github over ssh? Do you normally use password authentication instead of ssh?
It occurs to me, that some users might not even use ssh - so apart from being able to setup ssh on first-time use, it should ask whether to use ssh or password, right?

@epixa
Copy link

epixa commented Feb 1, 2018

@sqren I recommend encouraging best practices (ssh) through this tool rather than supporting other use cases (passwords) just because they exist. You could always add the password stuff if there was enough demand for it.

@sorenlouv
Copy link
Owner

@epixa That's a good point. I was not looking forward to supporting several authentication mechanisms.

@sorenlouv
Copy link
Owner

@liza-mae were you able to solve your problem by adding github.com to you known hosts before running backport? ssh github.com should do the trick.

@liza-mae
Copy link
Author

Hi @sqren , yes that did work for me. Thanks.

@sorenlouv
Copy link
Owner

Good to hear!
Closing in favor of #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants