Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't choose keepers with db behind a defined lag as masters #251

Closed
sgotti opened this issue Mar 25, 2017 · 0 comments
Closed

Don't choose keepers with db behind a defined lag as masters #251

sgotti opened this issue Mar 25, 2017 · 0 comments
Labels
enhancement

Comments

@sgotti
Copy link
Member

sgotti commented Mar 25, 2017 •
edited
Loading

One features we forgot to implement was the way to avoid choosing a standby or an old master behind a predefined maximum lag as masters (this can happen only with asynchronous replication)

This is usually avoided checking that the keeper is not at the required cluster spec version but under some circumstances, with asynchronous replication, it may happen. So having a defined maximum lag is required.
@sgotti sgotti changed the title Don't choose standbys behind a defined lag as masters Don't choose keeper with db behind a defined lag as masters Apr 24, 2017
@sgotti sgotti changed the title Don't choose keeper with db behind a defined lag as masters Don't choose keepers with db behind a defined lag as masters Apr 24, 2017
sgotti added a commit to sgotti/stolon that referenced this issue Apr 24, 2017
@sgotti
sentinel: don't choose keepers with db behind a defined lag as masters.
109833a 
Add a new cluster spec option `MaxStandbyLag` which defaults to 1MiB and
honor its value when choosing eligible standbys/old master.

Fixes sorintlab#251
@sgotti sgotti mentioned this issue Apr 24, 2017
Merged
sgotti added a commit to sgotti/stolon that referenced this issue Apr 25, 2017
@sgotti
sentinel: don't choose keepers with db behind a defined lag as masters.
3e29e5f 
Add a new cluster spec option `MaxStandbyLag` which defaults to 1MiB and
honor its value when choosing eligible standbys/old master.

Fixes sorintlab#251
sgotti added a commit to sgotti/stolon that referenced this issue Apr 25, 2017
@sgotti
sentinel: don't choose keepers with db behind a defined lag as masters.
5587b86 
Add a new cluster spec option `MaxStandbyLag` which defaults to 1MiB and
honor its value when choosing eligible standbys/old master.

Fixes sorintlab#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgotti